Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport "Merge pull request #6238 from Hartmnt/fix_volume_slider_keyboard" to 1.5.x #6294

Closed
wants to merge 1 commit into from

Conversation

Krzmbrzl
Copy link
Member

Backport

This will backport the following commits from master to 1.5.x:

Questions ?

Please refer to the Backport tool documentation

Previously, when using keyboard arrows or the mouse wheel,
the new slider widget action applied the new local volume
but did not save it. That was because it used the sliderReleased
event to save the value, which is not triggered by keyboard or mouse
wheel updates.

We could simply save the local volume on every sliderChange instead of
on sliderRelease, but that would cause many writes to the disk
in a short period of time and possibly lag the client.
Additionally, the ListenerVolumeSlider would spam packets to the
server, as the listener volume is saved server-side.

This commit introduces event filters in addition to the sliderChanged event,
which are observing key releases and mouse wheel events.
It also introduces a delay timer for packets send to the server from the
ListenerVolumeSlider.

Fixes #6211

(cherry picked from commit 6213ed4)
@Krzmbrzl
Copy link
Member Author

Krzmbrzl commented Jan 1, 2024

Backport not needed

@Krzmbrzl Krzmbrzl closed this Jan 1, 2024
@Krzmbrzl Krzmbrzl deleted the backport/1.5.x/pr-6238 branch January 13, 2025 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants